Google Git
Sign in
chromium / chromium / src / 348ff9f3242e39e1e4d514cc89b7889aa17ca605
commit348ff9f3242e39e1e4d514cc89b7889aa17ca605[log] [tgz]
authorDominique Fauteux-Chapleau <domfc@chromium.org>Fri Jun 10 18:21:14 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 10 18:21:14 2022
treefe615abdc723f9da1aa82e4012212924f0d107c0
parent72c8689c7d6d7d5199dc408fad6f30425b3a0bce [diff]
Revert "Feed launch reliability logging: remove incorrect 'launch finished' logs"

This reverts commit 7851454ba24476e8349853a5d0d35d22d0736a80.

Reason for revert: Seems to have broken Android compilation, see https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/26580/overview

Original change's description:
> Feed launch reliability logging: remove incorrect 'launch finished' logs
>
> TabModelObserver.didSelectTab() and TabObserver.onPageLoadStarted() can both be called as part of the NTP loading process and can't be relied on to signal that the user is leaving the feed during loading.
>
> Bug: 1195940
> Change-Id: I8a9fffaa2dcd68ccc91aa2904802b2dad3e488e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3699011
> Reviewed-by: Peter Williamson <petewil@chromium.org>
> Commit-Queue: Ian Wells <iwells@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1012970}

Bug: 1195940
Change-Id: I7670d9efc9c80d1bf5b80050402ded441843cfb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696165
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Dominique Fauteux-Chapleau <domfc@google.com>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1013035}
4 files changed
tree: fe615abdc723f9da1aa82e4012212924f0d107c0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.