[AXTreeFixing] Add short delay and re-request for transient state This CL cleans up some parts of the AXTreeFixing services router to be more convenient for clients/testing, and to cover an edge-case. With this CL, we add a retry mechanism for requests for main nodes in favor of the previously existing queue (which is kept in the code with a TODO to address it after final UX). There can be short transient states, like ScreenAI starting up, that result in the need to retry a request after a short delay if we do not store a queue in a state. We update the impl in web_contents to no longer use hard CHECKs, to cover the case where a page is already fully loaded before a user turns on accessibility services. In this case, the observers and the services router can be spun up before the BrowserAccessibilityManager for each RenderFrame is ready, so rather than doing a CHECK, we revert to the original implementation of returning an empty AXTree, and using that as a signal to retry the request after a short delay. We update some comments and add a request counter member variable to ensure we don't do many repeated requests, which is a sign of something wrong that is not a transient state. AX-Relnotes: N/A Bug: 395134535, 401050816 Change-Id: I604b0fab822887b689419664e48a573bbedb9d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6426603 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Jocelyn Tran <jocelyntran@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/main@{#1442369}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.