Google Git
Sign in
chromium / chromium / src / 34aaa2b2693e30a3d22bbeaa8887b318a36ad132
commit34aaa2b2693e30a3d22bbeaa8887b318a36ad132[log] [tgz]
authorLambros Lambrou <lambroslambrou@chromium.org>Tue Apr 10 18:03:21 2018
committerCommit Bot <commit-bot@chromium.org>Tue Apr 10 18:03:21 2018
tree1085101234cd070610506d8acc7e500dd907151d
parenta7585d7975a744e6b13db14bc074169d2f74239d [diff]
[remoting WebRTC] Ensure SDP messages end with \r\n

This modifies the host to generate SDP messages with CRLF line-endings.
Both host and client already accept incoming SDP with CRLF or just LF.
However, the normalized form of SDP for signature-verification uses
just LF endings, and we need to maintain this for compatibilty.
So this CL introduces two normalized forms, one with CRLF endings for
sending SDP, and one with LF endings for signature calculation.

Bug: 830974
Test: Unittests, and manual end-to-end test using Chrome beta (M65).
Change-Id: I061637cf639af97184295e4a1b23aa4b663e246d
Reviewed-on: https://chromium-review.googlesource.com/1003773
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549587}
4 files changed
tree: 1085101234cd070610506d8acc7e500dd907151d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. webrunner/
  55. .clang-format
  56. .eslintrc.js
  57. .git-blame-ignore-revs
  58. .gitattributes
  59. .gitignore
  60. .gn
  61. .vpython
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .