Google Git
Sign in
chromium / chromium / src / 34d5b59a67da7b0ea1a3eb90835467eb63e7262e
commit34d5b59a67da7b0ea1a3eb90835467eb63e7262e[log] [tgz]
authorJayson Adams <shrike@chromium.org>Tue Jan 23 18:59:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 23 18:59:25 2024
treecb989ace0ff673e05be62a995beed1c9d0aa09f8
parentf24d1b8dd62513b60dead55c115f6b1620af2747 [diff]
[Mac A11y Sonoma] Refine a11y detection and enablement on macOS Sonoma

The behavior of signals we rely on for enabling accessibility has
changed in macOS Sonoma, causing Chrome to activate screen reader
support when it's not necessary (which consumes memory). This cl
refines our accessibility support detection heuristics. Specifically:

* Uses KVO to watch specifically for VoiceOver state changes
* Wraps updates to AXEnhancedUserInterface in in a timer, to filter out spurious updates
* When we receive an accessibilityRole request, and VoiceOver is not active, turn on ui::kAXModeBasic (kNativeAPIs + kWebContents)

Bug: 1509023

Test: out/Debug/browser_tests --gtest_filter=ChromeBrowserAppMac*
Low-Coverage-Reason: OTHER - coverage check is wrong

Change-Id: I4a0742630d127431179bd02be7e1b14751f7d25b
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5112830
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1250961}
8 files changed
tree: cb989ace0ff673e05be62a995beed1c9d0aa09f8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.