Pass triggeringMotionEvent from AppMenu to onMenuOrKeyboardAction()

This CL is a no-op. It only changes method signatures.

Context:

* Tab closure will have different behavior depending on whether a click
  came from a peripheral. For example, when using a peripheral to close
  all tabs via the app menu, we don't want to show the "undo" snackbar.

* With http://crrev.com/c/6555582, we are able to obtain the
  MotionEvent that triggered a click on an AppMenu item, so we can use
  it to differentiate between peripheral clicks and other clicks.

* This CL passes the click-triggering MotionEvent from
  AppMenuItemViewBinder to
  MenuOrKeyboardActionController.onMenuOrKeyboardAction() where the
  actual click-handling logic lives.

  Similar work was done for the grid tab switcher:
  http://crrev.com/c/6521282.

* The change involves a few interfaces. The code path is:
  AppMenuItemViewBinder ->
    [interface] AppMenuClickHandler.onItemClick() ->
       [impl] AppMenu.onItemClick()
    AppMenuHandlerImpl.onOptionsItemSelected() ->
    [interface] AppMenuDelegate.onOptionsItemSelected ->
      [impl] ChromeActivity.onOptionsItemSelected()
      [impl] CustomTabActivity.onOptionsItemSelected()
    [interface] MenuOrKeyboardActionController.onMenuOrKeyboardAction()
      [impl] ChromeTabbedActivity.onMenuOrKeyboardAction()
      [impl] ChromeActivity.onMenuOrKeyboardAction()
      [impl] BaseCustomTabActivity.onMenuOrKeyboardAction()
      [impl] CustomTabActivity.onMenuOrKeyboardAction()
      [impl] WebappActivity.onMenuOrKeyboardAction()
  This CL adds the click-triggering motion event as a parameter of the
  methods above.

* To limit the scope of the CL, current interface methods are kept as
  default implementation. For example:

  ```
  public interface AppMenuClickHandler {

    // Generally there's no need to override this method.
    default void onItemClick(/* current params */) {
      onItemClick(
        /* current params */, /* triggeringMotionEvent= */ null);
    }

    // Implementations should always implement this method.
    void onItemClick(
      /* currentParams */, MotionEvent triggeringMotionEvent);
  }
  ```

Bug: 375468032
Change-Id: I90019b2c02f54af6123280e4099c1b1dbcede585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6557444
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Linyu He <linyuh@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1461729}
14 files changed
tree: e12d6820fe09f41ea0105e37d2efdaed17d171ef
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. SECURITY_OWNERS
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.