commit | 0ae80a944acd8ad36f26ce500157dd0f1d40d286 | [log] [tgz] |
---|---|---|
author | Victor Fei <vicfei@microsoft.com> | Tue Sep 07 17:27:32 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 07 17:27:32 2021 |
tree | bc87e8de9ba536cd55b5d38d64164abb053626a1 | |
parent | 85d6b1ee6763e8b761c659551fe00ef66cb25fad [diff] |
Deprecate old createPreviousFormatStartPosition logic This change removed old logic for AXPosition ::createPreviousFormatStartPosition and replaced with AXPosition:: CreateBoundaryStartPosition. CreateBoundaryEndPosition is a format type (word, char, line, paragraph, format) agnostic method to determine boundary position. ---- Overview of subsequent format position changes ------ The goal of this change is to eventually improve Narrator format navigation, since currently we don't distinguish between TextBoundary::kForwardStart\kFormatEnd. In the future, we need to introduce, ax::mojom::TextBoundary::kFormatStart\kFormatEnd, and introduce AXPosition::Create*Previous*FormatEndPosition and AXPosition::Create*Next*FormatStartPosition, so we will have the following create format methods: 1. When move START endpoint by format (FWD): - Create*Next*FormatStartPosition (doesn't exist, needs to impl). 2. When move END endpoint by format (FWD): - we call Create*Next*FormatEndPosition (method already exists). - Olg logic needs to be deprecated. Addressed in a different CL. 3. When move START endpoint by format (BWD): - Create*Previous*FormatStartPosition (already exists) - Addressed in this current CL. 4. When move END endpoint by format (BWD): - Create*Previous*FormatEnd (doesn't exist, needs to impl). The above to match the behavior for MoveByLine, Paragraph, and should improve Narrator format navigation. Ax-Relnotes: n/a Change-Id: I7193e65be7d463a24253d8db894be37f70fe4013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3134740 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/main@{#918833}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.