commit 34f953d4cb4e5019709dd93d4a32223dd487b9da
author luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Wed Jan 22 22:04:26 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 22 22:04:26 2025
tree 303fedf4dc411ef82f2d1899e65cca25f1ee8ba1
parent 012c3ef611cffc4d482b693853fc0b367241837b

Revert "Fix: Safely delete browsers on shutdown"

This reverts commit 0883dc5859694ef5dbcab5006f9c8c81c8358028.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5703485266853888

Sample build with failed test: https://ci.chromium.org/b/8725020453320881169
Affected test(s):
[ninja://chrome/test:browser_tests/TabManagerTest.DiscardTabsWithOccludedWindow/RetainedWebContents](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FTabManagerTest.DiscardTabsWithOccludedWindow%2FRetainedWebContents?q=VHash%3Addee393e1fa4b060)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5703485266853888&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6179704&type=BUG

Original change's description:
> Fix: Safely delete browsers on shutdown
>
> The current code for deleting browsers on shutdown is not safe because closing a browser window may close other browser windows (e.g., popin feature). The current approach of copying the list of browsers before deleting is not enough to ensure safety.
>
> This change introduces an observer to keep the list of browsers up to date, ensuring that browsers are deleted safely.
>
> Bug: 388400226
>
> Change-Id: I158a22170bfbaf614fdd884d57ddd4dc653490c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179704
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1409687}
>

Bug: 388400226
Change-Id: Ia9f36e75cc081a9ea43a36742ae9f37a90fa397a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192304
Reviewed-by: Solomon Kinard <solomonkinard@chromium.org>
Owners-Override: Solomon Kinard <solomonkinard@google.com>
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1409956}