| commit | 05e6a21733434a36607107c53f4970bfb620105f | [log] [tgz] |
|---|---|---|
| author | Timothy Loh <timloh@chromium.org> | Mon Aug 22 08:02:14 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 22 08:02:14 2022 |
| tree | 23457efdd70120a728d40a6496668b289ca5fdf0 | |
| parent | 313c54ba56edd2295c07ce87672054e43cf53238 [diff] |
Fix using invalidator iterator in CrostiniRestarter::ExtractRequests std::vector::erase(iterator) invalidates the iterator so we should use the return value to advance instead of the now-invalid iterator. This is covered by CrostiniManagerRestartTest.StartVmOnlyThenFullRestart, which already passes as in practice the iterator is a pointer which would point to the next element following the deletion. Bug: 1354175 Change-Id: I1df33f557dc4d920a3342313c4a6a5810051704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3844581 Commit-Queue: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1037591}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.