commit 3540140ea74396b6fd97ff4b45cd5199e017768c
author Daniel Andersson <dandersson@chromium.org> Tue Sep 10 16:39:07 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 10 16:39:07 2024
tree d7358b42abb15bb78afd0ecb247af264c54f4133
parent 3b4c4553b005b257d3c4db2b2d4197cada259ba2

ash: Fix crash when creating a new desk while exiting overview

DeskBarViewBase observes desk creations and does the necessary work to
update the desk bar. If the desk bar is in its "zero state" (the
collapsed desk bar state in overview mode), it expands the desk bar to
show mini views.

When exiting overview, there's a short animation that happens with the
desk bar. The events are as follows:

  1. Overview exit starts, the overview grid is immediately destroyed.
  2. Animation progresses.
  3. When the animation finishes, the desk bar is destroyed and it
     automatically unregisters itself as a desk controller observer.

If a new desk is created during #2, the desk bar would incorrectly
determine that we are still in overview mode and downstream code would
assume that the overview grid still exists. This CL fixes that check so
that we don't think overview mode is still active.

BUG=b:365546169

Change-Id: Ie8e39cbedaeeef3dbd89090000ce1210f639278b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5846865
Commit-Queue: Daniel Andersson <dandersson@chromium.org>
Reviewed-by: Yongshun Liu <yongshun@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1353411}