commit 356008f6abff54cf9c1417cc04cc4d9fe2e3722c
author Colin Blundell <blundell@chromium.org> Mon Mar 11 14:31:19 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 11 14:31:19 2024
tree e8d56c001c08b58ca4398ea9f27f03f659f0d2fa
parent b8a70ea83ee1c8d7468f4f752eb0b3683cb9149a

[//components/exo] Remove exo::Buffer::Texture::texture_target_

This field is used only in Buffer::Texture::CopyTexImage(texture), where
it is the `texture_target_` field of `texture` that is used. The latter
is called only once in the codebase [1], wherein a Texture instance that
was created via the constructor that does not take in a GMB was passed
[2].  That constructor correctly hardcodes the texture target to
GL_TEXTURE_2D (as seen in the changes in this CL), as it creates
RGBA_8888 SharedImages [3] for which GL_TEXTURE_2D is always used as the
texture target on ChromeOS.

This CL removes this field and hardcodes the texture target used there
to GL_TEXTURE_2D. We note that the texture target passed to the
MailboxHolder for the SharedImage of the Texture in question here is in
fact already hardcoded to GL_TEXTURE_2D.

[1] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/buffer.cc;l=728-733;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/buffer.cc;l=718-723;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[3] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/buffer.cc;l=214-237;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[4] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/buffer.cc;l=734-735;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1

Bug: 41494843
Change-Id: I980e7b2702bbe15643555653204b3b16f915c666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5360915
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270947}