Google Git
Sign in
chromium / chromium / src / 358e628f98a8861dcc474e94e132b502b1233fd8
commit358e628f98a8861dcc474e94e132b502b1233fd8[log] [tgz]
authorJun Ishiguro <junis@google.com>Fri Aug 18 01:40:59 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 18 01:40:59 2023
treea1c06c58f5985589e485c8222bed3f79d44465a1
parent1f954f1f0fb99dad152c7feeec3f7794fb555e99 [diff]
Change localized-link element to trigger click handler on middle-click

This CL makes <localized-link> elements trigger the click handler when
the user middle-clicks.

This change fixes an issue in ChromeOS where the OS settings page is
reloaded when the user middle-clicks on a special link, which has a '#'
href. The cause is that the default action of middle click is to open
the "link" in a background tab. For such links with JavaScript click
handler, the default action should be suppressed. By invoking the click
handler on auxclick events as well, the click handler can disable the
default action by the preventDefault() API.

Bug: 1457122
Change-Id: I1a392a1468def246bb960dbcd305db0582b04a5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780830
Commit-Queue: Jun Ishiguro <junis@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1185004}
2 files changed
tree: a1c06c58f5985589e485c8222bed3f79d44465a1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.