commit 358f12337716232dcd1362933968711e1e83526e
author Marijn Kruisselbrink <mek@chromium.org> Tue Dec 10 17:55:29 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 10 17:55:29 2024
tree f551b16bc7e5d317efb3f19707cc4de77d0df5b6
parent 5c58ec3103ce034f5594f0ff6f4ea551234a623f

M132: Fix app shim creation on non-stable channel with ad-hoc signing.

This is a reland of commit d972a88a18664b4b33845e3f71a01f7124d5305b,
with a fix for the fuzzer compile failure.

Original change's description:
> [AppShims] Fix app shim creation on non-stable channel with ad-hoc signing.
>
> When adhoc signed app shims are enabled, web_app_shortcut_copier
> is used to copy the generated app shim to its final location.
> The way web_app_shortcut_copier tries to setup a mojo connection
> to the app that launched it relies on base::apple::BaseBundleID to
> return the same value in the browser and helper process. However
> unless a process explicitly sets this value, it will return the
> bundle ID of stable channel. As such breaking creation of app
> shims from anything other than chromium builds or chrome stable.
>
> Fix this by getting the bundle ID from chrome::OuterAppBundle in
> web_app_shortcut_copier; this should return the correct bundle
> as long as we override the framework bundle path correctly (which
> we do).
>
> Bug: 382015346
> Change-Id: I7323261b48070ed1dd7c5169863b409f00f7e60b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6067566
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Mark Rowe <markrowe@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1391280}

(cherry picked from commit 4907a4c7fa5193e259312e16982fecf5982596f3)

Bug: 382015346
Change-Id: I63f298386d6a7b69088ff32bfe31a15636fbb564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6068586
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1392416}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6081385
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/branch-heads/6834@{#1932}
Cr-Branched-From: 47a3549fac11ee8cb7be6606001ede605b302b9f-refs/heads/main@{#1381561}