Google GitGoogle Git
Sign in
chromium/chromium/src/3593fcd77cd95b9641deabbdbc2e4404590fa498
commit
3593fcd77cd95b9641deabbdbc2e4404590fa498
[log]
author
Alison Gale <agale@chromium.org>
Tue Apr 30 15:36:31 2024
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Apr 30 15:36:31 2024
tree
5a3f2b1009ea5dbd9a6cd4156edfa07b00ad3167
parent
38d9a5ecd05fe8d28437a6d31c41ffffe48aca2b [diff]
Highlight default prompt menu item in app menu

Adopting the pattern added in:
https://chromium-review.googlesource.com/c/chromium/src/+/5427510

When the update item (or any future item that is higher in the list)
then the default prompt item isn't highlighted. Otherwise it does
get highlighted.

Just default prompt: https://screenshot.googleplex.com/8t2kNqmuTi6mAL6
Default prompted + update:
https://screenshot.googleplex.com/AbiMhiYQmU6oXbq

Bug: 336324502
Change-Id: I4c62d28862e8be0b0a8595af84406924266d8e2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468465
Reviewed-by: Darryl James <dljames@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294355}
1 file changed
tree: 5a3f2b1009ea5dbd9a6cd4156edfa07b00ad3167
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.