| commit | 359c83b5cfdd20d27c938c279b298d83904e3e5b | [log] [tgz] |
|---|---|---|
| author | Traian Captan <tcaptan@chromium.org> | Wed Apr 17 01:02:38 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 17 01:02:38 2024 |
| tree | 8457c1a6f7006c6251210e8326a15e0b21d54198 | |
| parent | 90fc54f45d3c17314a795907d4eefb4c64d3aa5f [diff] |
Re-Enable AutoSizeLazyLoadedImages This patch enables the AutoSizeLazyLoadedImages flag by default. When enabled, lazy loaded images with `sizes=auto` will use the layout width of the image to select the source url from the srcset. For this use case the image's width and height should be provided. This was initially enabled in: https://chromium-review.googlesource.com/c/chromium/src/+/5100579 And switched back to experimental in: https://chromium-review.googlesource.com/c/chromium/src/+/5241231 due to several image skewing bugs reported. While investigating mitigation options for the skewing issues, it was ultimately discovered that they were caused by the interactions between contain-intrinsic-size and object-fit. This was brought up to the CSS WG in issue: https://github.com/w3c/csswg-drafts/issues/10116 The resolution was that contain-intrinsic-size should not affect object-fit. This was implemented in: https://chromium-review.googlesource.com/c/chromium/src/+/5442533 guarded by flag NoIntrinsicSizeOverride, which AutoSizeLazyLoadedImages depends on. Spec: https://html.spec.whatwg.org/#sizes-attributes Chrome Status: https://chromestatus.com/feature/5191555708616704 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/OAsmCbjPJz0/m/jzuTJzs1AAAJ R=pdr Bug: 1359051 Change-Id: I9463ec0f6ee40809dad9e7b359c2ba05bea1a2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458907 Commit-Queue: Traian Captan <tcaptan@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288450}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.