commit | 0a2b8d0b9b14d2abbf0dca750e51dde3e0a355ab | [log] [tgz] |
---|---|---|
author | Giovanni Ortuno Urquidi <ortuno@chromium.org> | Tue Nov 29 05:50:41 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 29 05:50:41 2022 |
tree | 1d43934770be04e2dfd8436a4c806ec078510ebf | |
parent | 8f65bb36f277b75dc2f57647de11a991c456bf67 [diff] |
Revert "Implement keyboard shortcut for Lens Region Search." This reverts commit 422b5c30cb847e3764ad8e6134c31d392ded7125. Reason for revert: Causing most official builds to fail. Original change's description: > Implement keyboard shortcut for Lens Region Search. > > Keyboard shortcut (Ctrl/Cmd + Shift + L) is temporary as the keyboard > shortcut has not yet been finalized. All code is flag-guarded so > keyboard behavior is unaffected when flag is disabled. > > Tested on Linux, Mac, and Windows; with flag disabled and enabled; and > with search engine set to Google, Bing (third-party search engine that > supports region search), and Yahoo (does not support region search). > Availability of keyboard shortcut is identical to that of region search > when flag is enabled. > > Screenshot of context menu item with keyboard shortcut label: > https://screenshot.googleplex.com/3MSyZ2kn9iGHDef > > Bug: 1392456 > Change-Id: Ifa4fb6297879d9ae4de3c0d9dc970c4878e52c04 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4043546 > Reviewed-by: Juan Mojica <juanmojica@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Bryan Nguyen <nguyenbryan@google.com> > Cr-Commit-Position: refs/heads/main@{#1076590} Bug: 1392456, 1394312 Change-Id: Ic6855d1e2afb6a7d8e98a18cc3ed53a7dbb3c083 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4063626 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076673}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.