| commit | 361b45ebed4c8c0b801819421f1de206f5a833ad | [log] [tgz] |
|---|---|---|
| author | Piotr Kotynia <piotrkotynia@google.com> | Tue Oct 15 13:07:59 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 15 13:07:59 2024 |
| tree | 23aae2c6518d508f971c47e7c3886af4ce8f5e10 | |
| parent | 1a672de5299c6a6650ce016a9baf890c9222d40c [diff] |
Refactor InputType button checks to use explicit enum comparisons This change replaces the virtual methods InputType::IsButton() and InputType::IsTextButton() with explicit checks against the InputType enum values. This refactoring: * Reduces the overhead of polymorphic function calls. * Improves readability by making the button type checks explicit. * Aligns the code with the existing conventions in the file. Additionally it removes a stale comment. Change-Id: Ie7c2890aedbc08c7a90fbfc6d5153e383461f449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5929090 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Christoph Schwering <schwering@google.com> Commit-Queue: Piotr Kotynia <piotrkotynia@google.com> Cr-Commit-Position: refs/heads/main@{#1368743}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.