Google Git
Sign in
chromium / chromium / src / 36879cb7856ea0aff04b156b222aa3837a7db13d
commit36879cb7856ea0aff04b156b222aa3837a7db13d[log] [tgz]
authorAnish Mishra <anishmishra@microsoft.com>Wed Jan 25 04:52:41 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 25 04:52:41 2023
tree454d3c3ce9a579281cfe3a3b038649bc419258f0
parentc3beb6d194760359aaa1d52535d3f1b59f1e65a3 [diff]
Fixing Combobox Arrow button to show role as button in accessibility tree

Prob Description:
The arrow control is reporting as a combobox, which is not aligned with W3's ARIA spec(link below).
[https://w3c.github.io/aria/#combobox]


In Windows the UIA tree structure convention states that the Arrow control should be a button in Combobox control(link below).
[https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-supportcomboboxcontroltype#typical-tree-structure]


Solution:
In order to fix the issue we need to change the role of Arrow button in EditableCombobox from kComboBoxMenuButton to kButton.

Bug: 1407068
Change-Id: Ibda3add1a3bc4fe4bf0eb11c0fa30f305ed0fa5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176214
Commit-Queue: Anish Mishra <anishmishra@microsoft.com>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1096622}
1 file changed
tree: 454d3c3ce9a579281cfe3a3b038649bc419258f0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.