commit 368c01fcaf6dac387152b5093b885f70961d3b9d
author Bruce Dawson <brucedawson@chromium.org> Fri Dec 02 00:39:07 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 02 00:39:07 2022
tree 81dbea5982b7ef5063136ae5a137dfb9b9690d29
parent f761e68b582ed2df92808c5affd41c0671737710

Optimize AddedJsFilesCheck

AddedJsFilesCheck invokes two filter functions, one that is passed
in and one that is local. It was invoking the passed-in function first
which is not ideal because that function may be expensive and if it is
called first it will be invoked on every file in the change.

This change reverses the order so that the local function is called
first. This works well because this function is cheap, and it rejects a
lot of files, thus reducing the load on the passed in function. This
makes CheckNoNewJs run about ten times faster (2.5 s instead of 25 s
when tested with presubmit --all). Some of the speedup (from 3.5s to
2.5s) is from making the local filter function even lighter weight.

While investigating this I noticed that CheckNoNewJs would fail if
CheckWebDevStyle wasn't run first, so this change also fixes that by
pulling out a function to import presubmit_support.

Change-Id: I2fb9d480fe0f0978210ba5cf3bf2b7cd0f65e010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4067910
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078379}