Google Git
Sign in
chromium / chromium / src / 36b41a7fee3a707593b5473ddaf1d10e90a327cc
commit36b41a7fee3a707593b5473ddaf1d10e90a327cc[log] [tgz]
authorDaniel d'Andrada <dandrader@google.com>Mon Oct 31 09:59:56 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 31 09:59:56 2022
treee8c05a72b3e8069da26ea04f75a34e61124b1187
parentdd9c532b2c4c4fd6101abc76881c7b72526dd7c1 [diff]
[Code Health] Remove notification usage in ExternalProviderImplChromeOSTest

Remove usage of NOTIFICATION_CRX_INSTALLER_DONE.

Part of the larger effort of removing the
NotificationService.

Also re-enabled tests that were changed as they were all creating observers and setting other preconditions *after* CheckForExternalUpdates() was already called, and CheckForExternalUpdates() is the method that kicks-off extension installation. This opens room for race conditions where, for instance, installation could complete before the observer is created.
Worth reenabling them to see if flakiness continues.

Bug: 1174728, 706506, 1181737, 1177118
Change-Id: Iff447d582dc75204a0f567070c3893282724ea2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3987563
Commit-Queue: Daniel d'Andrada <dandrader@google.com>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1065418}
1 file changed
tree: e8c05a72b3e8069da26ea04f75a34e61124b1187
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.