| commit | 36f9c72b03434d6b8c74d80e5bd6cb15afef9f66 | [log] [tgz] |
|---|---|---|
| author | nancy <nancylingwang@chromium.org> | Tue May 12 17:10:08 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue May 12 17:10:08 2020 |
| tree | b1aa39a874b0008c7258fc1b38f5142b63cd5f09 | |
| parent | 160fff53d8e264a496370258b7fc32d8af8b29e1 [diff] |
Fix the shelf icon load issue when the app is not pinned to the shelf. If the unpinned app has been launched for the second user, when switch to the second user, AppServiceAppIconLoader is called to load the icon at very early stage for the launched apps due to the session restore process. But ChromeLauncherController::ActiveUserChanged is not called yet, so AppServiceAppIconLoader for the first user is still used to load icons. Then ChromeLauncherController::ActiveUserChanged is called, and AppServiceAppIconLoader for the first user is destroyed, so the load icon callback can't be called to load icons. Modify ChromeLauncherController's app_icon_loaders_ to use a per profile based map. When loading icons, select the correct profile's app_icon_loaders_ to load icons. Modify ChromeLauncherController's OnAppInstalled and OnAppUpdated to reload icons for both the pinned app and launched unpinned app. Modify LauncherControllerHelper::GetAppTitle to use extensions to set the title for extensions only. BUG=1076540 Change-Id: I432047a4c965422f4721acb1fa6d6885f96faa01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189999 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#767849}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.