Fix the shelf icon load issue when the app is not pinned to the shelf.

If the unpinned app has been launched for the second user, when switch
to the second user, AppServiceAppIconLoader is called to load the icon
at very early stage for the launched apps due to the session restore
process. But ChromeLauncherController::ActiveUserChanged is not called
yet, so AppServiceAppIconLoader for the first user is still used to
load icons. Then ChromeLauncherController::ActiveUserChanged is called,
and AppServiceAppIconLoader for the first user is destroyed, so the load
icon callback can't be called to load icons.

Modify ChromeLauncherController's app_icon_loaders_ to use a per profile
based map. When loading icons, select the correct profile's
app_icon_loaders_ to load icons.

Modify ChromeLauncherController's OnAppInstalled and OnAppUpdated to
reload icons for both the pinned app and launched unpinned app.

Modify LauncherControllerHelper::GetAppTitle to use extensions to set
the title for extensions only.

BUG=1076540

Change-Id: I432047a4c965422f4721acb1fa6d6885f96faa01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189999
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#767849}
3 files changed
tree: b1aa39a874b0008c7258fc1b38f5142b63cd5f09
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.