Google Git
Sign in
chromium / chromium / src / 372d10aba87f79161dffda4a71674ce26db4c81c
commit372d10aba87f79161dffda4a71674ce26db4c81c[log] [tgz]
authorDaniel Andersson <dandersson@chromium.org>Fri Jul 15 22:10:22 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 15 22:10:22 2022
tree4c38dd6e28c44adef17217fdd6c6964ef40a113c
parent8c4d26fb0f3d290e5bec68b8e55fa8bf1ee45352 [diff]
saved_desks: Fix launching of single-instance apps for Save & Recall.

If a single-instance app is running and a saved desk that contains the
same app is launched, then we move the existing app over to the launched
desk.

The code to handle this in DesksController was making assumptions that
the window should be moved to the currently active desk. This was fine
for desk templates, but is not true for save & recall.

This CL updates the code to actually make use of AppRestoreData::desk_id
instead of assuming the currently active desk. This field is populated
when any saved desk is launched.

Note: most of the delta came from reorganization code so that we have
access to AppRestoreData earlier in the function and also unindenting
a chunk of code.

Tested: Tested on device with os://flags and lacros enabled.

Bug: 1344266
Change-Id: Ic3e60030608c14c35fd744b78af900dc2a085723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3766135
Commit-Queue: Daniel Andersson <dandersson@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1024926}
1 file changed
tree: 4c38dd6e28c44adef17217fdd6c6964ef40a113c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.