commit | 3773b71f7c519939d87e2199fa3a901b13289c13 | [log] [tgz] |
---|---|---|
author | Jeffrey Young <cowmoo@google.com> | Wed Mar 09 19:29:31 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 09 19:29:31 2022 |
tree | 3c890d5d871d2642730eafd4606c8106db21c5e6 | |
parent | e8fe77e43e50843fabcba3d32a2e9e18607ab646 [diff] |
wallpaper: remove a hack to clear old images When an img src tag is changed, the old image is visible while the new one loads. There was a previous hacky workaround for wallpaper that manually removed img src tags when navigating away from a wallpaper collection. This hack + switching to cr-auto-img in https://crrev.com/c/3488694 caused a bug where viewing the same wallpaper collection twice in a row incorrectly removed the img src attribute. Instead, build this into cr-auto-img with clear-src attr. When cr-auto-img receives a new auto-src attribute, clear the src first and then set the new src. This prevents the old image from being shown while the new one loads, and removes the need for a wallpaper specific hack. BUG=1304790 BUG=b:222752163 BUG=b:219799872 TEST=open wallpaper picker, navigate through collections, return to same collection after clicking back TEST=browser_tests --gtest_filter="*CrElementsAutoImgTest*" Change-Id: I048951e17af318e986f402ba1f85d1b6c2b7a5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3507496 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/main@{#979363}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.