wallpaper: remove a hack to clear old images

When an img src tag is changed, the old image is visible while the new
one loads. There was a previous hacky workaround for wallpaper that
manually removed img src tags when navigating away from a wallpaper
collection. This hack + switching to cr-auto-img in
https://crrev.com/c/3488694 caused a bug where viewing the same
wallpaper collection twice in a row incorrectly removed the img src
attribute.

Instead, build this into cr-auto-img with clear-src attr. When
cr-auto-img receives a new auto-src attribute, clear the src first
and then set the new src. This prevents the old image from being
shown while the new one loads, and removes the need for a wallpaper
specific hack.

BUG=1304790
BUG=b:222752163
BUG=b:219799872
TEST=open wallpaper picker, navigate through collections, return to
same collection after clicking back
TEST=browser_tests --gtest_filter="*CrElementsAutoImgTest*"

Change-Id: I048951e17af318e986f402ba1f85d1b6c2b7a5e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3507496
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979363}
5 files changed
tree: 3c890d5d871d2642730eafd4606c8106db21c5e6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.