| commit | 377ea73b94e3447719681ba487b7677f6ac64af0 | [log] [tgz] |
|---|---|---|
| author | Peter Kasting <pkasting@chromium.org> | Tue May 25 16:45:15 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 25 16:45:15 2021 |
| tree | 0f6285f23db7ac4f1f71e581c13c8a2371f68bf0 | |
| parent | 36b842ce7d4d2020e0cc9c186cd71ca1204850f9 [diff] |
Fix scoping for GURLs/Origins in some test file in chrome/. This is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/2008048 that updates some of the same files to use constants/methods scoped as narrowly as possible, to make more clear which pieces of functionality are interdependent. This was discussed on #cxx at the time Michael originally landed his changes and seemed the most desirable route forward. To some degree, one could argue this improves compliance with https://google.github.io/styleguide/cppguide.html#Local_Variables . Bug: 1042727 Change-Id: I7e09da20bd9bcb636c5ee15bc56c30d5339f77a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914420 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#886327}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.