commit | 37855993b8455236d35a391cb0c1f2fa33c44b88 | [log] [tgz] |
---|---|---|
author | Gastón Rodríguez <gastonr@microsoft.com> | Thu Nov 21 00:09:44 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 21 00:09:44 2024 |
tree | 1b511955bf1c0d841e3371a13cbefb00eb2d9627 | |
parent | 8a1365beabbfb3f7070778782188e49a75993026 [diff] |
Fix scaling for 9-patch scrollbars. When pinch-zooming in a subscroller that is being rendered with nine- patch scrolling the track shows strange behavior. In official builds the rendering of the thumb and arrows gets distorted and in local builds it is clear that the scrollbar's track and buttons are not being scaled. The root causes for this bug were: 1. The patch generator was not being passed the scaled rect by the layer code, it was only being given the layer's dimensions. 2. The track's bitmap wasn't being repainted when scaled, which in the best case scenario caused the arrows to look blurry, and in the worst it caused the rendering to be completely wrong. 3. The aperture wasn't being scaled to consider the bitmap's scaled dimensions, which caused scaled scrollbars to be rendered incorrectly. This CL: 1. Adds a new condition for the scrollbars to be re-painted whenever the layer's internal scale changes. 2. Refactors the ScrollbarTheme 9patch-Canvas and 9patch-Aperture code to consider the scale of the layer and return the correct sized values. 3. Adds web and unittests to cover the new behavior. Bug: 378027651 Change-Id: Ie467ecc8139e2a6b03d5d073ac2c860bf2cd571d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013524 Commit-Queue: Gaston Rodriguez <gastonr@microsoft.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Yaroslav Shalivskyy <yshalivskyy@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1385971}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.