Google Git
Sign in
chromium / chromium / src / 379806666d4d5f3ffbddfec2072178cea5c5585a
commit379806666d4d5f3ffbddfec2072178cea5c5585a[log] [tgz]
authorAhmed Fakhry <afakhry@chromium.org>Wed May 18 18:01:59 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 18 18:01:59 2022
tree620937f8e412d692bac733451cd4d8608c83cba5
parentbf36747c41bbf8742148a3f05d4cd15262f0ae05 [diff]
[Merge to M-103] capture_selfie_cam: Address UXImpl feedback

- When the folder selection dialog is shown, we decided
  to hide the camera preview along with all other capture
  UIs. Once the dialog is dismissed, the camera preview
  should show again.
  -->> A bug was found while working on this, a dismissed
       toast widget can be made visible again by mistake.
       Fixed in this CL.
- Clicking outside the bounds of the settings menu should
  dismiss it directly, rather than performing a capture, or
  selecting a region.

Fixed: 1325121
Test: Manual, added unit tests.

(cherry picked from commit c285c102014e2cfe5dd62be1f61cf7df4f608e61)

Change-Id: I09f7d74d3290b273776e0af45be9e4bdc2793188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646826
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004305}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653442
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ahmed Fakhry <afakhry@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{#82}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
7 files changed
tree: 620937f8e412d692bac733451cd4d8608c83cba5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.