Google Git
Sign in
chromium / chromium / src / 37a8c3ba71bef9d600fe2fe5b555070d8de05381
commit37a8c3ba71bef9d600fe2fe5b555070d8de05381[log] [tgz]
authorMark Mentovai <mark@chromium.org>Tue Feb 08 15:31:17 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 08 15:31:17 2022
tree4e183c8848593f60b439535eacb0451d108feab8
parentc8cd9442d858102fe4606c152d0c40de9fa02d22 [diff]
mac signing: Make pipeline_test.py Python 2-compatible again

7bf013ff60c1 and b2272b386993 added --skip-brand and --channel,
respectively, and enhanced the singing tests to test that these new
options behave correctly. The exception assertions they use are
dependent on the string representation of Python sets, which are
different in Python 2 (set(['a'])) and 3 ({'a'}). These scripts still
retain Python 2 compatibility, and sign_chrome.py runs on non-Chrome
infrastructure under #!/usr/bin/env python which is Python 2. The tests
should pass when run under both Python 2 and 3. This updates the test
expectations to match the values as formatted by each Python version
when running under that version.

Bug: 1291703
Change-Id: I96a5d56e81906ccf6bb35610dc9999f19d1ed2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446082
Auto-Submit: Mark Mentovai <mark@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968332}
1 file changed
tree: 4e183c8848593f60b439535eacb0451d108feab8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.