| commit | 37e18c33eec700f328ec95c0968a90ed798cc1cc | [log] [tgz] |
|---|---|---|
| author | Emilia Paz <emiliapaz@chromium.org> | Tue Jun 06 18:31:20 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 06 18:31:20 2023 |
| tree | b446f3ba141c126ae8240132d151c80ef8b381d9 | |
| parent | cf9e0bc1e09dbe4dbec7e726e3d909609c84f223 [diff] |
[Extensions cleanup] Remove ButtonVisibility in context menu model ButtonVisibility was used to determine whether the extension was pinned or not on the toolbar. The enum was in the extension context menu, but its computation was made in the extensions menu. This was problematic, because it's not a property that belongs to either of them. Instead we can directly retrieve whether the extension is pinned from the toolbar actions model and remove the enum. Bug: 1416359 Change-Id: If4c2da83eb36a471fb80e07f78480837bda7bcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573221 Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1153967}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.