[PWA] Load all screenshots unconditionally for detailed dialog This CL does the following: 1. Constructs the number of spaces in the detailed dialog based not on the number of screenshots available in the manifest, but on the number of screenshots to be downloaded. 2. Ensures that all screenshots are loaded unconditionally, except for if the bitmap does not draw anything. This is needed because empty bitmaps would crash the ImageModel [1] on debug enabled builds. https://source.chromium.org/chromium/chromium/src/+/main:ui/base/models/image_model.cc;l=153?q=ImageModel::GetImage Tested using https://cute-western-seer.glitch.me/ Fixed: 390075225 Bug: 372285217 Change-Id: I4b3f6db586711e0d85ada8a9469ff0e2f4ad8ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176912 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1406849}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.