commit | 96fb33f0c56da9580befe12bb5e9ac5e5b862b48 | [log] [tgz] |
---|---|---|
author | Nathan Memmott <memmott@chromium.org> | Wed Aug 14 15:55:27 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 14 15:55:27 2024 |
tree | a9f48b9d6b0800397905f6c05277fed4a6ddcd84 | |
parent | dae6372f8a4cf96d27b345d0fa9a7d14c6bf4374 [diff] |
Change Observer: Fix crash when navigating to new page The browser may crash if you navigate to a new page with an active FileSystemObserver observation. This is because the FileSystemAccessObserverObservation is a FileSystemAccessPermissionGrant::Observer of the root handle's read grant. And when the permission status changes, it destroys itself along with the read grant if its the only holder of the read grant. This means that when you navigate to a new page, RevokeActiveGrants attempts to iterate through all the active grants of the page and revoke them. But since its iterating over an array that FileSystemAccessObserverObservation removes an element from during that iteration, it get an invalid iterator. The fix is to increase the iterator before continuing. Fixed: 359567614 Change-Id: I3eea7340527e0255bdaa7488cf6e4968b299483e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786874 Reviewed-by: Daseul Lee <dslee@chromium.org> Commit-Queue: Nathan Memmott <memmott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1341696}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.