Google Git
Sign in
chromium / chromium / src / 385c06fcf899706307c27a2b80f320d93dbdca1c
commit385c06fcf899706307c27a2b80f320d93dbdca1c[log] [tgz]
authorCaroline Rising <corising@chromium.org>Thu Sep 12 14:01:44 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 12 14:01:44 2024
tree1959b3278570b5079afff5eefa7155afba06c787
parenta0a164acbe386e290a86e346415005e3cb65df09 [diff]
Reland "Reland "Disable customize chrome context menu item when customize chrome isn't registered.""

This is a reland of commit 62361738e694763ead55a911d18d82107653d7ef

See patchset 1 vs 2 for the test failure fix. This test started failing because we added a check that verifies that customize chrome is registered to the tab's registry and the test was ensuring registry to the window's registry.

Original change's description:
> Reland "Disable customize chrome context menu item when customize chrome isn't registered."
>
> This is a reland of commit dd6a0645bb72aa8ba8cf4cf7ba3c9b27f7238de6
>
> See patchset 1 vs 2 for the difference which adds the missing dep that
> this was reverted for to chrome/browser/ui/views/toolbar/BUILD.gn
>
> Original change's description:
> > Disable customize chrome context menu item when customize chrome isn't registered.
> >
> > This also adds a check in BrowserCommandController to not try to open
> > the customize chrome side panel if it is not registered which it checks
> > for the customize chrome side panel controller. Also add test.
> >
> > Bug: 364340028
> > Change-Id: I2478f0bb0b845eb92b4e18dfb21e3bf8bc7d56e5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5846012
> > Commit-Queue: Caroline Rising <corising@chromium.org>
> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > Reviewed-by: David Pennington <dpenning@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1353291}
>
> Bug: 364340028
> Change-Id: I132ae8d117d03241253ebb880d1190a2ad34e827
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850510
> Reviewed-by: David Pennington <dpenning@chromium.org>
> Commit-Queue: Caroline Rising <corising@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1353965}

Bug: 364340028, 365953512
Change-Id: Ic07e461efe95536b009ce8f8d15ae93d557f4c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854947
Commit-Queue: Caroline Rising <corising@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354512}
5 files changed
tree: 1959b3278570b5079afff5eefa7155afba06c787
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.