commit | 387b61732a4ca2f25d7aa5b376de0d373e4e72c2 | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Wed May 11 06:40:32 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 11 06:40:32 2022 |
tree | 4add7d505d2574d24bb59fd0eda66c1b874ffca9 | |
parent | fbb49391f8b72039b0c5c03c7241c3be2ff2a5d3 [diff] |
Reland "CSS highlight painting: bump HighlightOverlayPainting to stable" This is a reland of commit abc6f616c7bc2c53cc9d8c44b82384d43dd77d02 Original change's description: > CSS highlight painting: bump HighlightOverlayPainting to stable > > This patch enables the new highlight overlay painter. The rebaselined > tests and their reasons are as follows: > > • no more double painting bug > • dark-mode/colors/selection.html > • originating decorations are now recolored per spec > • editing/selection/line-wrap-2.html > • virtual/text-antialias/selection/khmer-selection.html > • spelling markers are now *consistently* painted over text > • paint/markers/document-markers-font-8px.html > • paint/markers/document-markers-zoom-2000.html > • decorations are now clipped to highlight background rect > • svg/text/text-selection-deco-01-b.svg > • svg/text/text-selection-text-03-b.svg > > The only new failure expectations are as follows: > > • external/wpt/css/css-pseudo/highlight-painting-003.html broadens > from Mac11 to Mac (like we had to do in CL:3608432) > • external/wpt/css/css-text-decor/text-decoration-color-selection-001 > fails because the test is incorrect (bug 1321106) > • paint/markers/suggestion-marker-basic.html fails because it’s not > clear the assertion still complies with the spec (bug 1321114) > > Some tests had bugs that we’ve fixed in this patch: > > • external/wpt/css/css-pseudo/target-text-text-decoration-001.html > had a bug where it assumed UA default highlight colors would be > suppressed by an author ‘text-decoration’ > > Bug: 1147859 > Change-Id: Ie4d8dae515a786fa01e8f2852d645f3a8ad313be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616170 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Delan Azabani <dazabani@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1001604} Bug: 1147859 Change-Id: Icd150ff8c695d20a5c9f44df45d5e0751c31f79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3640642 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/main@{#1001937}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.