Google Git
Sign in
chromium / chromium / src / 38b8c5fc3a42de19bf3c3589169ed48a15db0c7b
commit38b8c5fc3a42de19bf3c3589169ed48a15db0c7b[log] [tgz]
authorrbpotter <rbpotter@chromium.org>Fri Dec 03 05:51:54 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 03 05:51:54 2021
treef304de5dda2030ee7b3485a15d8ac01b4bc70edb
parent5fb8424836913a9405fbc62051936422a1b289cb [diff]
Reland "Print Preview: Migrate key event, link container and layout tests to TS"

This reverts commit 47920f3d805feefe65e8e5e1160fca44fb64232d.

Reason for revert:
One line fix, PS2->PS3

Original change's description:
> Revert "Print Preview: Migrate key event, link container and layout tests to TS"
>
> This reverts commit 1c703f052b7eb2b6b432e240e51223bbe2433224.
>
> Reason for revert: Made KeyEventTest.CmdPeriodClosesDialogOnMacOnly flaky
>
> Bug: 1276217
>
> Original change's description:
> > Print Preview: Migrate key event, link container and layout tests to TS
> >
> > Also updating various Print Preview key handling code to use event.key
> > rather than event.code.
> >
> > Bug: 1245834
> > Change-Id: Ib1fadcb17d94bdcae710421ed7c991df6d25fe61
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310197
> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#947690}
>
> Bug: 1245834
> Change-Id: I4370d072201a09b19545e73689e9bf8fdbeaa169
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312930
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Tsuyoshi Horo <horo@chromium.org>
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Owners-Override: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#947819}

Bug: 1276217
Bug: 1245834
Change-Id: I89c6074ebd3dd6929d2a9d8d3a3d01f6cd88a8df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313493
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#947895}
10 files changed
tree: f304de5dda2030ee7b3485a15d8ac01b4bc70edb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.