Google Git
Sign in
chromium / chromium / src / 38cde2c6282cbe8650590352b51ef7824fa2bc80
commit38cde2c6282cbe8650590352b51ef7824fa2bc80[log] [tgz]
authorLouis Romero <lpromero@google.com>Fri Jan 05 16:36:58 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 05 16:36:58 2024
treea9436bf1769d8ad180c462b56481724e2f7d9838
parent77008a9b1ceaf532a95bfa89bc85452f1db7e9c0 [diff]
Dismiss the keyboard when dragging Tab Grid search results

This CL dismisses the keyboard as soon as the scrollview with the search
results is scrolled.

Prior to the new Compositional Layout, this was not an issue, as there
was a bug where the Suggested Actions had a way too large height,
leading to the Suggested Actions not being able to be occluded by the
keyboard. But the Compositional Layout gives it its correct height,
leaving it hidden behind the keyboard.

An alternative fix would be to subscribe to the keyboard notifications,
and adapt the scroll view's additional safe area insets but it's more
cumbersome.

Fixed: 1515895
Change-Id: I411b5bb0deb9fa62e4e43805a2eb5d2601da891e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5172556
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243454}
1 file changed
tree: a9436bf1769d8ad180c462b56481724e2f7d9838
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.