| commit | 391c297321751db54551d4025e1d9eef5f62e108 | [log] [tgz] |
|---|---|---|
| author | Zachary Tan <tanzachary@chromium.org> | Thu May 25 19:06:44 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu May 25 19:06:44 2023 |
| tree | 7da7ff6e59d8dfd0fc2a7984f68ebb283cfa4605 | |
| parent | d3bf302ac72147e0c0665d0984f1c8ee2506eb4a [diff] |
[FedCM] Change IDP sign-in status/AuthZ modal dialog to pop-up window Although a modal dialog would provide better UX, a pop-up window works better with existing features such as WebAuthn. This change would allow us to get to a working prototype sooner rather than later. We will rename modal dialog to pop-up window in a future patch. A screenshot of the pop-up window is available on https://bugs.chromium.org/p/chromium/issues/detail?id=1430830#c15 Bug: 1430830 Change-Id: I3356ae2e1f8058f5542ec9218137812a451db050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4561997 Reviewed-by: Sam Goto <goto@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Zachary Tan <tanzachary@chromium.org> Cr-Commit-Position: refs/heads/main@{#1149281}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.