commit | 39226c47eaeff1b31c79c468a80a4be3d97f4904 | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Fri Nov 01 08:50:12 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 01 08:50:12 2024 |
tree | 097ffca082ec69782d23c48e1ad5aeb794b2d525 | |
parent | b67fa75dd0c19e0d1f880426ca94337de6ea3ab4 [diff] |
Revert "Remove views::test::IsOzoneBubblesUsingPlatformWidgets()" This reverts commit 60646016c6fcb6c296cbec1fbe9c80fe7fe39155. Reason for revert: talking to the original author of the kOzoneBubblesUsePlatformWidgets feature (fangzhoug@), it was mentioned that the feature might still be useful to other platforms, eg linux, with some work. This CL, then, reverts the original removal. In a follow up CL, the lacros checks will be removed instead. Original change's description: > Remove views::test::IsOzoneBubblesUsingPlatformWidgets() > > This CL removes the aforementioned method and its respective calls > sides. > Today it always returns FALSE as it bool-checks whether > `features::kOzoneBubblesUsePlatformWidgets` is enabled, something that > only happens in Lacros builds. > Now that Lacros project is terminated, the method became no-op. > > In a follow up I will coordinate with kramer (fangzhoug@) the removal of > the feature flag+impl. > > R=hidehiko@chromium.org, neis@chromium.org > > Bug: 375937556, 374244479, 373971535 > Change-Id: Ia9aea5ef8a469f197dd4f8661f46ee223cc748a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5973705 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/main@{#1376017} Bug: 375937556, 374244479, 373971535 Change-Id: I5b7af7df319041c6a68b89c41204db5e70407d8f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979515 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1376793}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.