Google Git
Sign in
chromium / chromium / src / 39292c4da979d32e84591768c02ee60e90ff3150
commit39292c4da979d32e84591768c02ee60e90ff3150[log] [tgz]
authorDevlin Cronin <rdevlin.cronin@chromium.org>Wed Dec 28 22:02:39 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 28 22:02:39 2022
treed1c3f601333cc20548fff0dff2259c089f26cbf9
parent6205d8a0eb0f45ca4a9557f5fa6a305d17bc255b [diff]
[Extensions] Don't have object-src fall back to default-src in CSP validation

Currently, if an object-src is specified in a Manifest V3 extension, it
is required to be a local resource. Since object-src falls back to
default-src if no object-src is specified, we also currently validate
that the default-src is a local resource if no object-src is specified.

Stop doing this, so that developers can specify a non-local default-src
without needing to specify a separate object-src. This has no security
implications because:
- The minimum CSP (which includes `object-src self`) will still be
  appended in all cases.
- Other directives (like script-src) that fall back to default-src if
  unspecified will still require a local default-src.

Update tests for the same.

Bug: 1320785
Change-Id: I014dd8e2967484e2086bf0ea0c603be4c2e8119c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127606
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1087425}
3 files changed
tree: d1c3f601333cc20548fff0dff2259c089f26cbf9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.