Google Git
Sign in
chromium / chromium / src / 393c1b144320af4688db5110b67a70f5fbeca5a2
commit393c1b144320af4688db5110b67a70f5fbeca5a2[log] [tgz]
authorTommy C. Li <tommycli@chromium.org>Wed May 22 00:28:41 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 22 00:28:41 2019
treedf3faaa40e87d2d7d9cdf224bad4371f0f2adcec
parentae59bbaacd76e934f653d2eaabbdb3e84f3abf0c [diff]
[omnibox] Move "ZeroSuggestVariant" to be a context sensitive param

Currently for ZeroSuggestProvider, "ZeroSuggestVariant" is simply
globally configured.

This CL moves "ZeroSuggestParam" to operate using the existing
GetValueForRuleInContext, which allows it to be parameterized by
the page classification.

In other words, this CL allows us to configure different
On Focus Suggestion modes per page classification.

This will likely be used to put the search results page in a custom
query refinement On Focus Suggestion mode.

Bug: 963173
Change-Id: If7df3c4a7fc4906788f0a466b7a6edeccd614b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617208
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661999}
6 files changed
tree: df3faaa40e87d2d7d9cdf224bad4371f0f2adcec
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .