Google GitGoogle Git
Sign in
chromium/chromium/src/39b90a7ddd3d4fe10d5fccb75a315698cd235080
commit
39b90a7ddd3d4fe10d5fccb75a315698cd235080
[log]
author
Kuo Jen Wei <inker@google.com>
Wed Aug 04 03:30:56 2021
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Aug 04 03:30:56 2021
tree
986bbecab9c3ba6c87822bfb5e12c01e900f40be
parent
07441ba981199d6e5784e31f571328258f67473b [diff]
CCA: Check video track muted state before take photo

Chrome use muted state on video track representing no frame input
returned from preview video for a while[1] and call |takePhoto()| with
video track in muted state will fail with |kInvalidStateError|
exception.  To mitigate chance of hitting this error, here we ensure
frame inputs from the preview and checked video muted state before
taking photo.

[1]
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediastream/video_track_adapter.cc;drc=d0b89fe9c3d6ecc1ec4ffaf0baeb6b36c34ba7fd;l=833

Bug: b/189584023, b/192846832, b/192601240
Test: tast run <DUT> "camera.CCAUI*"
Change-Id: I950a1e036d3c1f2fc39c6d6a49328ecdcf8553bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3066804
Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Inker Kuo <inker@chromium.org>
Auto-Submit: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908314}
5 files changed
tree: 986bbecab9c3ba6c87822bfb5e12c01e900f40be
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.