Google Git
Sign in
chromium / chromium / src / 39e266d529cdd4db3fcbe427345e8fe04baa93fe
commit39e266d529cdd4db3fcbe427345e8fe04baa93fe[log] [tgz]
authorMunira Tursunova <moonira@google.com>Thu Jan 25 13:21:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 25 13:21:20 2024
tree5add147c14b6119ee1cb0ab4b3a0bd5d9862d386
parent29a56640086270cc9c5412e8a832b520442ede9f [diff]
Request bold trait in system UI font matching

Sometimes, when we match Mac system UI font by italic traits and then
adjust weight and width variations [0], we end up getting a CTFont
which has a correct `wght` variation axis value, but it's trait value is
not updated.

This behaviour was only observed for Mac's system UI font of size 14px,
see [1] or for the same Mac system UI font in the smaller sizes (i.e.
<8px), compare [2].

This CL proposes a workaround solution that adds bold trait if
requested, in addition to italic trait, during system UI font matching.

[0] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/fonts/mac/font_matcher_mac.mm?q=MatchSystemUIFont
[1] https://crbug.com/1520661
[2] https://crbug.com/1516731

Bug: 1516731
Change-Id: Id375df428de5de242d5dcca48aed6c71863298af
Cq-Include-Trybots: luci.chromium.try:mac13.arm64-blink-rel,mac13-blink-rel,mac12.0-blink-rel,mac12.0.arm64-blink-rel,mac11.0-blink-rel,mac11.0.arm64-blink-rel,mac10.15-blink-rel,mac_chromium_10.15_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224989
Commit-Queue: Munira Tursunova <moonira@google.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252037}
13 files changed
tree: 5add147c14b6119ee1cb0ab4b3a0bd5d9862d386
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.