Google Git
Sign in
chromium / chromium / src / 3a63134e538b3ea2c7c5075d0753b368c5f8f548
commit3a63134e538b3ea2c7c5075d0753b368c5f8f548[log] [tgz]
authorFindit <findit-for-me@appspot.gserviceaccount.com>Thu Feb 25 09:45:49 2021
committerMarkus Heintz <markusheintz@chromium.org>Thu Feb 25 09:45:49 2021
tree96babd33bde164db750656c6065df14a0df860b2
parent304760e4a7543f6aef7d0d6d66689eff0a565c52 [diff]
Revert "Sheriff: Use DeathTest naming for a death test."

This reverts commit 8161e2e2ae9a802329cc24bcab3550d6cf6ca5c0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 857596 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgxNjFlMmUyYWU5YTgwMjMyOWNjMjRiY2FiMzU1MGQ2Y2Y2Y2E1YzAM

Sample Failed Build: https://ci.chromium.org/b/8854335151009651920

Sample Failed Step: compile

Original change's description:
> Sheriff: Use DeathTest naming for a death test.
> 
> Per suggestions in https://chromium.googlesource.com/external/github.com/google/googletest/+/refs/tags/release-1.8.0/googletest/docs/FAQ.md#but-i-don_t-like-calling-my-entire-test-case-foodeathtest-when-it-contains-both-death-tests-and-non_death-tests_what-do-i-do
> 
> Bug: 1181697
> Change-Id: I9e1663c99ad2ff156053d0ed3255fd2d02dee77f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718758
> Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#857596}


Change-Id: I84d473bb1606fa70df69cb9dc431f1ccaa5b82b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1181697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2717974
Cr-Commit-Position: refs/heads/master@{#857598}
1 file changed
tree: 96babd33bde164db750656c6065df14a0df860b2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.