Ensure callback is called if dialog is closed via system back

When the WARN dialog is closed via the system back, the copy or paste
action callback is not triggered. This can cause some issues, as certain
systems may find themselves in a problematic "intermediate" state.
Triggering the callbacks with null pointers is sufficient to "reset" the
system, essentially the same thing as the user acknowledging the warning
and cancelling the attempted clipboard action.

This also *technically* affects blocked actions too, but since blocked
actions are always blocked, in practice this has a much less visible
effect.

Copy actions are affected in that future copies don't work, as the copy
logic is rigid and will be stuck with a permanent `pending_writes > 0`.
So if a dialog is dismissed, future dialogs will still appear, but
attempting to "copy anyways" will just not work. This does also affect
blocked actions, but in practice all copies on that site will be
blocked, so this should never be observed.

Paste actions are more severely affected, with the entire tab freezing
up. Leaving and returning is possible and does fix things. This freezing
doesn't affect blocked actions, since there's already code in place
triggering a callback call to clear state.

Bug (copy):
https://screencast.googleplex.com/cast/NDc5MzAzODQ4NzQyMDkyOHwwNDc3NzJjMi0xMA

Bug (paste):
https://screencast.googleplex.com/cast/NDc0ODYwNTY3NTAxMjA5NnwxODc1MDAxMi05Yg

Fix (paste):
https://screencast.googleplex.com/cast/NTEyNjA1NDMxMzE5NzU2OHw4NTBlMGVmMy0zMw

Fix (copy):
https://screencast.googleplex.com/cast/NTY5MjEzMzMzNDg0MzM5Mnw1YjMwYjI2Yi04MQ

Bug: 434871993
Change-Id: I2d9dee442fd122f3a311cdc662af9b327ee959a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7003982
Reviewed-by: Nancy Xiao <nancylanxiao@google.com>
Commit-Queue: Charles Hager <clhager@google.com>
Cr-Commit-Position: refs/heads/main@{#1523920}
1 file changed
tree: b91ce4caa453d8fcd8860799610fda346e842e01
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.