Reland "Android: Make official build symbolization work"
Original CL: https://crrev.com/c/5477688
Fixed:
- Removed crashpad_database_util as it results in local crashes.
Although dump_syms can be downloaded from BinaryManager, it is better
and more reliable for symbolization if it is always built.
This CL adds it as a data dep of official builds.
Bug: 332553182
Fixed: 332553182
Change-Id: I158ab52b44c164bdf78c392d39038f4c7d55f0b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497836
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293878}
diff --git a/chrome/android/chrome_public_apk_tmpl.gni b/chrome/android/chrome_public_apk_tmpl.gni
index ad7fdf8..d1d81d6 100644
--- a/chrome/android/chrome_public_apk_tmpl.gni
+++ b/chrome/android/chrome_public_apk_tmpl.gni
@@ -557,6 +557,12 @@
data_deps += [ "//chrome/android:android_lint" ]
}
+ # Official builds need the dump_syms binary for symbolizing. This is a small
+ # binary necessary for debugging official builds. Ensure it is built.
+ if (is_official_build) {
+ data_deps += [ "//third_party/breakpad:dump_syms" ]
+ }
+
shared_libraries = []
loadable_modules = []
if (android_64bit_target_cpu) {
diff --git a/tools/cygprofile/orderfile_generator_backend.py b/tools/cygprofile/orderfile_generator_backend.py
index db47944..c193b557 100755
--- a/tools/cygprofile/orderfile_generator_backend.py
+++ b/tools/cygprofile/orderfile_generator_backend.py
@@ -259,10 +259,8 @@
self._step_recorder.RunCommand(
['gn', 'gen',
str(self._out_dir), '--args=' + ' '.join(gn_args)])
- # Always build dump_syms as it's required by
- # generate_breakpad_symbols.GetDumpSymsBinary in order to symbolize stacks.
self._step_recorder.RunCommand(self._ninja_command +
- [str(self._out_dir), target, 'dump_syms'])
+ [str(self._out_dir), target])
def _ForceRelink(self):
"""Forces libmonochrome.so to be re-linked.
