Google Git
Sign in
chromium / chromium / src / 3ab74d4710158db6af44e044dffe4727bcc23e8c
commit3ab74d4710158db6af44e044dffe4727bcc23e8c[log] [tgz]
authorAndrew Rayskiy <greengrape@google.com>Fri Aug 02 17:43:47 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 02 17:43:47 2024
tree01816689349022d70bc307bc79ae9966d4fe6275
parent40ea4d1eed4bc6709b375a8c4faa5a8ab0b4bbec [diff]
Reland "iwa: Optimistically update IWAs when key rotation happens"

This is a reland of commit ec89d463d3901ff14afd0a4a87de7e62c31e7c4f

What changed: ScopedBundledIWA's destructor was never called which led
to a memory leak.

Original change's description:
> iwa: Optimistically update IWAs when key rotation happens
>
> This CL wires up IsolatedWebAppUpdateManager to listen to component
> installations and check for updates of affected IWAs accordingly.
>
> Same-version update attempts are now allowed if they might lead to the
> set of signing keys changing.
>
> Faulty updates (when the new bundle doesn't contain the rotated key) are
> simply ignored for now -- the exact handling is TBD.
>
> Bug: 353489152
> Change-Id: I16b00e7a5d51e653192ccff7e8726ba212281001
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5729755
> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> Commit-Queue: Andrew Rayskiy <greengrape@google.com>
> Cr-Commit-Position: refs/heads/main@{#1336147}

Bug: 353489152
Change-Id: I4f1c179a685deeb188d18de1159a686283c15d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5757202
Auto-Submit: Andrew Rayskiy <greengrape@google.com>
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1336691}
17 files changed
tree: 01816689349022d70bc307bc79ae9966d4fe6275
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.