commit 3acb21571bf2961c1a0f5cdccd4045cca7f0a999
author Abigail Klein <abigailbklein@google.com> Wed May 10 20:42:49 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 10 20:42:49 2023
tree b6821bf35a0f3cb8951b351cdac4ed5ec712106b
parent 4cf2c320c294a1f35362a94f2615b8127d14e7be

Revert "Clear the main page selection when the side panel selection clears."

This reverts commit 0c6cb33a628e090624ee3170f51545fb5171c524.

Reason for revert: This CL causes the main page to jump to the top
when the user makes a null selection, losing the user's scroll
position. The goal of selecting is to let a user be able to easily
keep the main page and reading pane in sync, but when the scroll
jumps, it's jarring and the user loses their place.

Screen recordings:
With the original CL (notice jumping): https://drive.google.com/file/d/1n7DEIOMbSqMyG1aHc2nJRpf5-gGO_632/view?usp=sharing
With the CL reverted (notice no more jumping):
https://drive.google.com/file/d/1UklMhBGutD14ZoWr0FEJDglBlxFUUIjx/view?usp=sharing

The bug that the original CL was fixing is not as severe as the bug
it introduced, which is why I propose a revert.

Original change's description:
> Clear the main page selection when the side panel selection clears.
>
> Previously, the main page would keep the highlight even if the side panel clears.
>
> One quirk: clicking inside the existing selection on the side panel returns a null anchor and focus node, while clicking outside the existing selection does not. Both actions clear the side panel's selection but I had to add a check for those null nodes and force clear the selection.
>
> Demo: https://drive.google.com/file/d/1KcDsEvOmw7JXR25VpsMUAaBQYVuC_Pwm/view?usp=sharing&resourcekey=0-E73EqINVqjbB2HzZtqS7zA
>
> Bug: 1430990
> Change-Id: I50b2fb5a35d3ac8c5ba76959b06dd6d9a447f7f9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482680
> Reviewed-by: Abigail Klein <abigailbklein@google.com>
> Commit-Queue: Kristi Saney <kristislee@google.com>
> Cr-Original-Commit-Position: refs/heads/main@{#1138664}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4500624
> Cr-Commit-Position: refs/heads/main@{#1139269}

Bug: 1430990
Change-Id: I4d7dff413b4fa65e8fbf72430c65ad4b1e6cd6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4519222
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kristi Saney <kristislee@google.com>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/main@{#1142340}