commit 3ad1886eebfcfddbae34601739d59ada1e0c7eaf
author Thomas Thrainer <thomasth@google.com> Tue Mar 25 16:39:44 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 25 16:39:44 2025
tree ae033e5595df704c680913f15a6965531903cf8e
parent 7c9b4a308990b184b1eacac089ebc6286f8b22bc

Make local key recovery / device registration expandable.

Introduce a LocalRecoveryFactor interface that supports recovering
Keychain keys from locally stored keys and registering the local device
as recovery factor. The logic around the physical device as recovery
factor is refactored into PhysicalDeviceRecoveryFactor which implements
LocalRecoveryFactor. StandaloneTrustedVaultBackend is extended to
support a list of LocalRecoveryFactor's for key retrieval.

This CL only introduces negligible behaviour changes (and thus no tests
were updated):
  * storage_->WriteDataToDisk() is called twice instead of a single time
    in StandaloneTrustedVaultBackend::StoreKeys().
  * storage_->WriteDataToDisk() is called twice instead of a single time
    as a result of MaybeRegisterDevice() (in the
    PhysicalDeviceRecoveryFactor::OnDeviceRegistered() and
    StandaloneTrustedVaultBackend::OnDeviceRegistered callbacks).
  * Generally, storage_->WriteDataToDisk() is often called instead of
    WriteDataToDiskAndNotify(). However, the "notify" part is only used
    in tests, and there are no tests which depend on notifications in
    the changed code paths.

Follow-up CLs will
  * Refactor UMA metrics to work for multiple local recovery factors.
  * Make StandaloneTrustedVaultBackend support multiple local recovery
    factors for device registration.
  * Add tests for various cases when multiple local recovery factors are
    present.
  * Add a second LocalRecoveryFactor which will use the iCloud Keychain
    on MacOS for registration / key retrieval.

Bug: b:398160323
Change-Id: Ib242924d3ade19b1dc8e6c67bc00735bd80ce32a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6368662
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Thomas Thrainer <thomasth@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/main@{#1437544}