Google Git
Sign in
chromium / chromium / src / 3b1d961f269a5dca01c67c60d75353dbccef1239
commit3b1d961f269a5dca01c67c60d75353dbccef1239[log] [tgz]
authorNihar Majmudar <niharm@google.com>Mon Jan 22 18:56:22 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 22 18:56:22 2024
treed8aa72f81ad81c644e91b8e42c78ce5e9588da40
parentb6f6e47d38fb3fd69179b42136bfe1950d495081 [diff]
[webui][omnibox] Fix focus state for action chips and remove icon.

This CL
1) Fixes adds the focus ring for action chips in the WebUI omnibox.
Action chips were not receiving focus because "hidden" keeps the
cr-realbox-action's in the DOM and there were multiple
cr-realbox-action's in the shadow root. Switching these to dom-if
templates allowed them to be removed from the DOM.
2) Fixes some focus state logic. Before, the focus ring would not be
removed from the last focused item in a match when tabbing to the next
match.

Not fixed:
1) The focus state still stays on the match when tabbing through actions
and the remove button
2) Focus still doesn't work for headers.

Before:
https://screencast.googleplex.com/cast/NTM4MzQ2ODA3MzYxNTM2MHxmMTk2OWFmNi0xMQ
After:
https://screencast.googleplex.com/cast/NTQyMDU2OTc5NjI4MDMyMHw4OGEwYzM5OS1mMg

Bug: 1499279
Change-Id: I7cd1e8a2899cb97cc7466abbf7237e679200abd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5216188
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Nihar Majmudar <niharm@google.com>
Cr-Commit-Position: refs/heads/main@{#1250316}
10 files changed
tree: d8aa72f81ad81c644e91b8e42c78ce5e9588da40
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.