commit | 3b5779c5749d55973185a2391aa3726f9ddadc2f | [log] [tgz] |
---|---|---|
author | Keren Zhu <kerenzhu@chromium.org> | Thu Jun 30 02:17:35 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 30 02:17:35 2022 |
tree | 38fcb9523551465c1f5ea39fcc363b337e586853 | |
parent | f8e5723b9e160b73b4367ef85d863e4e6465b620 [diff] |
Reland "Use WebUI Color Pipeline in WebUI Tab Strip" This is a reland of commit 28591de4aedd13a3e4279ba4b5b1dea3a25b9f32 CrComponentsColorChangeListenerTest.All failed on mac arm64 because the machine runs so fast that two identical timestamps are generated (millisecond granularity) and used for the color css versioning. This reland fixes it by waiting for 1 millisecond before refresh. See patchset 1..6. Original change's description: > Use WebUI Color Pipeline in WebUI Tab Strip > > This CL migrates WebUI Tab Strip from the ad hoc theme support to the > more generic WebUI Color Pipeline. Specifically, > - Remove the tab strip mojo used for color passing. Use colors from > chrome://theme/colors.css instead. > - Use color_change_listener that will refresh WebUI colors on color > update (due to theme change or light/dark mode change) > - Assert that color_change_listener is only in desktop build. > > This is the first WebUI that uses color_change_listener and > chrome://theme/colors.css. > > Doc: use of color id in WebUI > https://docs.google.com/document/d/1lZzeWvvczGaI-zVo4ekwd53-Mmss6_tdVbPiEwj88_o/edit?usp=sharing > > Bug: 1261912 > Change-Id: I9f3206c9d293b4358f160c1f6a198e54fb5e726e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702665 > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Commit-Queue: Keren Zhu <kerenzhu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1018954} Bug: 1261912 Change-Id: Ib8008374accf0bcb1fcc3a1fd11059e1a59bb04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3735205 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#1019428}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.