Google Git
Sign in
chromium / chromium / src / 3b659d0f18bf8f08354a8c35a25b51e542eed659
commit3b659d0f18bf8f08354a8c35a25b51e542eed659[log] [tgz]
authorAdrian Taylor <adetaylor@chromium.org>Thu Mar 17 14:23:47 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 17 14:23:47 2022
treee4473cb3b2980a0f80db19e5c269884a1498af9c
parent59a6ff5594ce4315feffea4aadc215e851d7287d [diff]
[rust] Export cxx.cc symbols

This is a version of
https://github.com/dtolnay/cxx/pull/1025
backported to the version of cxx which we currently use,
plus associated GN changes to trigger that behavior.

Purpose of this change:
The Rust cxx interop tool produces both Rust and C++ side code for its
bindings. It also has fixed C++ code for some of its interop types (e.g.
the C++ representation of a Rust string). In most cases, all of this
ends up in the same binary, but in debug component builds a test
executable may have Rust code which needs to use thse symbols from (for
instance) libbase.so. We already previously exported the symbols for
dynamically generated bindings code; we now export the symbols for the
fixed C++ code too.

The patch within this change should be removed if/when
https://github.com/dtolnay/cxx/pull/1025
is accepted upstream and we have rolled cxx to include it.

Bug: 1287545
Change-Id: I6a0f76fcf6afb36718d5e939c797e7988826bad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3531194
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982195}
3 files changed
tree: e4473cb3b2980a0f80db19e5c269884a1498af9c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.