Google Git
Sign in
chromium / chromium / src / 3b77929e00058466651ec054a9a58bbe681b1313
commit3b77929e00058466651ec054a9a58bbe681b1313[log] [tgz]
authorJoemer Ramos <joemerramos@chromium.org>Fri Oct 14 00:37:36 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 14 00:37:36 2022
tree08cd3e302fc4e0335bc7e7c23cf755cce9697254
parentaf46662c992bd803635ebcfe9847574e631d854b [diff]
[iOS] Change TailoredSecurityServiceInfobarDelegate constructor

To make code simpler, we have decided to have the infobar delegate
call methods that happen on an infobar interaction (primarily the main
button being tapped) instead of the TabHelper. In order for the button
to interact properly, we need to pass a WebState into the delegate
when constructing so it can interact with the SafeBrowsingTabHelper and
have access to the associated ChromeBrowserState. Additionally, unit
tests were added to test the outputs of the overridden Accept() being
called.

Bug: 1357605
Change-Id: Ic01d4fa39d37a5a8dedda6763a10f1e67c7e747e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3946782
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Joemer Ramos <joemerramos@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1059027}
9 files changed
tree: 08cd3e302fc4e0335bc7e7c23cf755cce9697254
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.