Google Git
Sign in
chromium / chromium / src / 3b7b2636d85f684e8b0c6e26d7ae65a8da976428
commit3b7b2636d85f684e8b0c6e26d7ae65a8da976428[log] [tgz]
authorEric Sum <esum@google.com>Fri Feb 04 08:46:13 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 04 08:46:13 2022
treee51044178d726c6c383da163fc69032c487b8984
parent95b3bf4f4811ff887b105c4d5c3bfabdd105a290 [diff]
Add image asset dimensions to skottie resource metadata.

The ash team would like this information so that we have a guide for
how to transform (scale, crop, etc) our images before passing them
to Skottie.

As discussed offline, the easiest way to do this is to just parse
the JSON ourselves. Since this is information that could be useful
to other Chromium Skottie users as well, it's been added to the
cc::SkottieResourceMetadata. It's been plumbed all the way to the
cc::SkottieFrameDataProvider. Ash's implementation of that API
will start using the dimensions in the next CL.

Bug: b:217271214
Change-Id: I34d69efb78855f1fec314ca94095f77921c0705b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435071
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Eric Sum <esum@google.com>
Cr-Commit-Position: refs/heads/main@{#967143}
16 files changed
tree: e51044178d726c6c383da163fc69032c487b8984
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.